2021-03-08T18:13:43 <BenW> ^^
2021-03-08T18:16:00 <BenW> > ExclimationMark
2021-03-08T18:16:00 <BenW> :P
2021-03-08T18:18:37 <linusg> hf!
2021-03-08T18:21:19 <BenW> "There cannot be more unused bits than the entirety of the input" ^^
2021-03-08T18:21:25 <BenW> I love statements like these
2021-03-08T18:21:27 <BenW> whl!
2021-03-08T18:21:37 <linusg> hbw!
2021-03-08T18:21:57 <linusg> I see you're still collecting quotes :D
2021-03-08T18:25:14 <kling> hl!
2021-03-08T18:25:20 <linusg> hk!
2021-03-08T18:29:47 <CxByte> hl!
2021-03-08T18:30:04 <linusg> hcxb!
2021-03-08T18:30:23 <linusg> I see you're still fixing shell bugs :D
2021-03-08T18:32:26 <CxByte> there is no end to shell bugs
2021-03-08T18:35:03 <tomuta_> BenW: geez, finally got those test cases you pointed out to pass....
2021-03-08T18:35:15 <BenW> XD
2021-03-08T18:35:36 <BenW> tomuta_: Now you know why I ranted so much about overflow-correct code :D
2021-03-08T18:36:04 <BenW> Do you have a particular usecase in mind? I'm surprised that you added so much API and 0 callsites.
2021-03-08T18:36:11 <tomuta_> Hehe tbh I didn't look at your changes until i started trying to rebase my smp branch
2021-03-08T18:36:25 <CxByte> "Does your code contain unexpected integer overflow? of course it does! contact BenW to find out why!" (Overflow-correct code is deviously hard. https://github.com/SerenityOS/serenity/commit/183b2e71ba8d85293db493cab27b8adb4af54981)
2021-03-08T18:36:54 <tomuta_> In there I was using timestamps to detect if I should dump stack traces, but that code changed from u64 to Time, so I needed Time math ;)
2021-03-08T18:36:54 <BenW> Ohh yeah, I forgot about that.
2021-03-08T18:37:21 <BenW> Maybe it would be a good idea to merge some parts of that branch? This way you don't have to spend 90% of your time just rebasing :S
2021-03-08T18:37:26 <BenW> CxByte: <3
2021-03-08T18:38:00 <BenW> CxByte: Although, strictly speaking his code did *not* contain an integer overflow, or any kind of UB. It returned the wrong result for a different reason :P
2021-03-08T18:38:02 <tomuta_> BenW: that's my goal but there are some patches that will make non-smp really slow (due to many other unsolved problems)
2021-03-08T18:38:25 <BenW> Hmm, that makes sense.
2021-03-08T18:38:38 <BenW> Wait, no, it doesn't.
2021-03-08T18:39:10 <BenW> People will still run Serenity on single-core (virtual) machines, so we shouldn't grind to a halt, even when the branch finally gets merged.
2021-03-08T18:39:17 <CxByte> BenW: "Does your contain correctly handle overflow? of course not! BenW can tell you why!"
2021-03-08T18:39:26 <CxByte> s/your /&code/
2021-03-08T18:39:28 <BenW> CxByte: That's the spirit! XD
2021-03-08T18:39:52 <BenW> "Does your code contain correctly handle overflow?" still doesn't make much sense though
2021-03-08T18:40:01 <CxByte> dammit
2021-03-08T18:40:08 <BenW> CxByte: Are you hearing 95 voices? https://github.com/BenWiederhake/95voices#95voices
2021-03-08T18:40:46 * CxByte is curious what it would generate
2021-03-08T18:41:14 <BenW> Well, there's an example in the readme, and I recently ported it to python3, so feel free to give it a try! ^^
2021-03-08T18:42:33 <CxByte> Of Does Does your your contact code code BenW to correctly contain course find out handle it unexpected does! overflow? why! integer overflow?
2021-03-08T18:42:44 <SerenityBot> Make UserspaceEmulator emulate again! (BenWiederhake opened: The build passed.) https://github.com/SerenityOS/serenity/pull/5697 https://github.com/SerenityOS/serenity/actions/runs/633273764
2021-03-08T18:42:50 <CxByte> "overflow? why!"
See also all other quotes.